Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .doc to .syncValue and return undefined when not ready #125

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

pvh
Copy link
Member

@pvh pvh commented Aug 3, 2023

This is a pretty big behavioural change but should work nicely for environments where the value is checked frequently. If it's only read once, the user will be confused by getting undefined back but maybe that's okay?

@pvh pvh requested review from acurrieclark and alexjg August 3, 2023 06:49
@pvh pvh linked an issue Aug 3, 2023 that may be closed by this pull request
@pvh pvh merged commit fef9543 into main Aug 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocHandle.value and DocHandle.doc are confusing
1 participant